Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve link sharing experience #1204

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Improve link sharing experience #1204

merged 1 commit into from
Mar 14, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 14, 2024

Pull Request Description

This PR aims to improve the sharing experience across the board with a few changes.

  1. Any time you share a Lemmy link, you should be greeted by a menu which has options for sharing relative to the original instance or your home instance (if not the same) or with Lemmy syntax (if applicable).
  2. The "advanced share sheet", which was previously an optional share experience (and the default), is now just an item in the regular post share sheet.

These changes apply to the following share areas (see demos for each):

  • Post card long-press menu
  • Post body
  • Comment card long-press menu
  • Community app bar
  • User app bar

Issue Being Fixed

Issue Number: #1047, #1054

Screenshots / Recordings

Post card long-press menu

qemu-system-x86_64_VCIC8ZwEIx.mp4

Post body (same as long-press menu)

qemu-system-x86_64_p5gSttE9eZ.mp4

Comment card long-press menu

qemu-system-x86_64_3C5MuvQHyr.mp4

Community app bar

qemu-system-x86_64_u94uS3EgDF.mp4

User app bar

qemu-system-x86_64_Cym9VfV9sv.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 187d846 into thunder-app:develop Mar 14, 2024
1 check passed
@micahmo micahmo deleted the feature/improve-sharing branch March 15, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu